Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation if id is Model in deserializeRecordId #3279

Merged
merged 2 commits into from
Jun 14, 2015
Merged

Deprecation if id is Model in deserializeRecordId #3279

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbbbb63
Deprecation if id is Model in deserializeRecordId
joelalejandro Jun 10, 2015
45662c5
Better deprecation message in deserializeRecordId
joelalejandro Jun 10, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/ember-data/lib/system/store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2058,6 +2058,7 @@ function deserializeRecordId(store, data, key, relationship, id) {

//If record objects were given to push directly, uncommon, not sure whether we should actually support
if (id instanceof Model) {
Ember.deprecate("You tried to push a record '" + relationship.parentType + "'' with id '" + Ember.inspect(id) + "' and passed a DS.Model instance as a value for the relationship '" + key + "'. You should instead pass a numerical or string id to represent the record.");
data[key] = id._internalModel;
return;
}
Expand Down