-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT request-state-service] implements RFC 466 #6207
Conversation
packages/-ember-data/tests/integration/request-state-service-test.ts
Outdated
Show resolved
Hide resolved
|
||
class Person extends Model { | ||
// TODO fix the typing for naked attrs | ||
@attr('string', {}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @mike-north about fixing this, if it's not already fixed. This should be a 5 minute job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can also just do @attr() name;
packages/-ember-data/tests/integration/request-state-service-test.ts
Outdated
Show resolved
Hide resolved
type: 'mutation', | ||
state: 'fulfilled', | ||
request: { data: [savingRequestOp] }, | ||
response: { data: undefined } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double check. might be
response: { data: undefined } | |
response: { } |
77725db
to
9e6cca2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, lots of small cleanup to do but am 👍 to merge once that is done.
|
||
class Person extends Model { | ||
// TODO fix the typing for naked attrs | ||
@attr('string', {}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can also just do @attr() name;
packages/-ember-data/tests/integration/request-state-service-test.ts
Outdated
Show resolved
Hide resolved
packages/-ember-data/tests/integration/request-state-service-test.ts
Outdated
Show resolved
Hide resolved
packages/-ember-data/tests/integration/request-state-service-test.ts
Outdated
Show resolved
Hide resolved
7b3472c
to
b0628c4
Compare
b0628c4
to
143e1b2
Compare
RFC text