Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request state service #466

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Conversation

igorT
Copy link
Member

@igorT igorT commented Mar 15, 2019

@igorT igorT added the T-ember-data RFCs that impact the ember-data library label Mar 15, 2019
@igorT

This comment has been minimized.

@igorT

This comment has been minimized.

@fullsailor

This comment has been minimized.

@igorT

This comment has been minimized.

@igorT

This comment has been minimized.

@dgeb
Copy link
Member

dgeb commented Jun 19, 2019

Discussed this further with @igorT today and agreed to the following:

  • the record-specific methods on the RequestStateService should have record-specific names (e.g. getPendingRequestsForRecord).
  • the RequestState interface type can be potentially expanded in the future to allow for hybrid requests.
  • the decision on whether methods that take a RecordIdentifier on RequestStateService should also optionally take a Record comes down to a matter of consistency (which is probably best decided by @igorT, @runspired, and others who are deeper into the implementation than I am)

I have no objections to merging now.

@igorT

This comment has been minimized.

@dgeb
Copy link
Member

dgeb commented Jun 23, 2019

I've reviewed the latest changes and approve.

@igorT igorT force-pushed the igor/request-state-service branch 2 times, most recently from 8e6709c to a5d7769 Compare June 29, 2019 03:38
@igorT igorT force-pushed the igor/request-state-service branch from a5d7769 to 95d3ebb Compare June 29, 2019 03:41
@igorT igorT merged commit 86fdfaf into emberjs:master Aug 14, 2019
@igorT igorT deleted the igor/request-state-service branch August 14, 2019 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Final Comment Period T-ember-data RFCs that impact the ember-data library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants