-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "[BUGFIX] Fix an issue with concatenatedProperties."
This reverts commit 0158de0.
- Loading branch information
1 parent
56e5a22
commit f1ce398
Showing
3 changed files
with
2 additions
and
38 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1ce398
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we realized this solution was incorrect, and actually broke some scenarios. #3516 is our latest attempt.
f1ce398
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit is broke the build, since there is a leaking initializer (registering 'store:main' from here ). Previously, this was benign because you could just register undefined factories, but as of 4e4ec7a that was changed and we raise an error if you attempt to register a factory is undefined.
This is fixed by #3516, but is that ready to merge?
f1ce398
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#3516 is now merged. Sorry got deep into some pairing and forgot..