Refactor Ember.Application.initializer to fix initializers bleeding or not running
#3516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `Ember.Application.initializers` was implemented as a concatenated property, which is works at class definition and instance creation time, but not when the field is mutated, which is what `Ember.Application.initializer` was doing prior to this commit. Also reverted concatenatedProperties change, which had been added to try unsuccessfully to address this issue.
ghost
assigned 
|
As I mentioned in the comments of f1ce398 here reverting the prior stop-gap solution is causing the builds to fail (due to a leaking initializer from here and the changes here which disallows registering undefined factories). Where does this PR stand? Ready to go, or does it need further thought/review? In the meantime we need to fix the builds by putting 0158de0 back in place or something... |
|
i'll merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
Ember.Application.initializerswas implemented as aconcatenated property, which is works at class definition and instance
creation time, but not when the field is mutated, which is what
Ember.Application.initializerwas doing prior to this commit.Also reverted concatenatedProperties change, which had been added to try
unsuccessfully to address this issue.