Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.13.0-beta1] Component-classNameBindings only adds first array element #11193

Closed
mydea opened this issue May 17, 2015 · 2 comments
Closed

[1.13.0-beta1] Component-classNameBindings only adds first array element #11193

mydea opened this issue May 17, 2015 · 2 comments
Milestone
1.13.x

Comments

@mydea
Copy link
Contributor

mydea commented May 17, 2015

With 1.13.0-beta.1, all items in a classNameBindings-Array for a component after the first item are ignored.

This means that the following:

classNameBindings: [":test1", ":test2"]

Will result in a component with the class test1, but not test2.

I made a quick jsbin to show the problem:

http://emberjs.jsbin.com/zoqexiyequ/1/edit
@mixonic
Copy link
Member

mixonic commented May 17, 2015

Confirmed. Absolutely a regression.

@mixonic mixonic added this to the 1.13.0 milestone May 17, 2015
mitchlloyd added a commit to mitchlloyd/ember.js that referenced this issue May 17, 2015
@mitchlloyd
Don’t stop iteration on first :class
dccea5f 
Fix for issue emberjs#11193
@mitchlloyd mitchlloyd mentioned this issue May 17, 2015
Merged
mitchlloyd added a commit to mitchlloyd/ember.js that referenced this issue May 17, 2015
@mitchlloyd
Don’t stop iteration on first :class
cda8675 
Fix for issue emberjs#11193
mitchlloyd added a commit to mitchlloyd/ember.js that referenced this issue May 17, 2015
@mitchlloyd
Don’t stop iteration on first :class
cb43551 
Fix for issue emberjs#11193
@rwjblue
Copy link
Member

rwjblue commented May 18, 2015

Fixed by #11194. Updated canary JSBin: http://emberjs.jsbin.com/jogaxa/1/edit?html,js.

@rwjblue rwjblue closed this as completed May 18, 2015
rwjblue pushed a commit that referenced this issue May 18, 2015
@mitchlloyd @rwjblue
Don’t stop iteration on first :class
79a4a29 
Fix for issue #11193
(cherry picked from commit cb43551)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.x
Development

No branches or pull requests
3 participants
@mixonic @rwjblue @mydea