[1.13.0.beta1] Don’t stop iteration on first :class in classNameBindings #11194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchlloyd
force-pushed
the
many-class-name-bindings
branch
from
dccea5f
to
cda8675
Compare
mitchlloyd
changed the title
| run(function() { view.createElement(); }); | ||
|
|
||
| equal(view.$().attr('class'), 'ember-view class-one class-two', "both classes are added"); | ||
| }) |
There was a problem hiding this comment.
JSHint cramping my style again. Fixed.
Fix for issue emberjs#11193
mitchlloyd
force-pushed
the
many-class-name-bindings
branch
from
cda8675
to
cb43551
Compare
|
Thanks man :-) |
mixonic
added a commit
that referenced
this pull request
May 18, 2015
[1.13.0.beta1] Don’t stop iteration on first :class in classNameBindings
|
Drat. I should have been more militant about using @rwjblue please note this for inclusion in beta! |
|
Well, good to know I'll try to keep that in mind going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #11193.