[BUGFIX release] Fix attributeBindings for id attribute.
#11889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In prior versions of Ember you could customize `id` via
`attributeBindings` like so:
```javascript
export default Ember.Component.extend({
attributeBindings: [ 'someThing:id' ]
someThing: 'asdfasdfasdf'
});
```
However, that was broken during the glimmer refactorings because we
process `attributeBindings` *before* the defaults (meaning the default
`elementId` is used whenever `id` isn't passed in the template).
This fix is to process the default first, then process `attributeBindings`.
|
LVGTM |
rwjblue
added a commit
that referenced
this pull request
Jul 25, 2015
[BUGFIX release] Fix `attributeBindings` for `id` attribute.
|
Will this be backported to 1.13? |
|
@Serabe - Yes, it has already been backported into the stable branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In prior versions of Ember you could customize
idviaattributeBindingslike so:However, that was broken during the glimmer refactorings because we
process
attributeBindingsbefore the defaults (meaning the defaultelementIdis used wheneveridisn't passed in the template).This fix is to process the default first, then process
attributeBindings.Fixes #11871