-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component rendering fails after upgrading to 1.1.1 #3637
Comments
It looks like (Stef) forgot to pull #3516 into the last beta. It is in the current beta: https://github.com/emberjs/ember.js/blob/v1.2.0-beta.1/packages/ember-application/lib/system/application.js#L679-L697 TL;DR initializers currently do not inherit at all. Using v1.2.0-beta.1 should be a viable alternative in the short term. We will bring this up with core, and decide if we need to drop a 1.1.2. (@stefanpenner + @twokul) paired this comment. (cc @wycats , @wagenet , @lukemelia et.al) |
Yeah, that commit wasn't properly tagged so it didn't get pulled over. |
We'll discuss it at the core team meeting tomorrow. |
Should be fixed by 1cd63d7. We'll do a 1.1.2 soon. |
I'm experiencing this bug in 1.2.0-beta.3. |
@skddc - Could you make a JSBin demonstrating the issue? |
Hmm, the jsbin works, so it looks like a bug in EAK or I'm just using it wrong. I'll investigate further and open an issue for EAK, if it's an actual bug. Thanks. |
Turns out I didn't know that component names can't be single words, and earlier versions didn't complain about it or show deprecations warnings, while it worked fine the way I used it. |
Ok, thanks. |
After upgrading to 1.1.1 (also tried 1.1.0) we get the following type of errors
Where xxxx-xxxx is a component name.
Our templates are pre-compiled using the latest ember-handlebars-compiler (https://raw.github.com/emberjs/ember.js/v1.1.1/packages/ember-handlebars-compiler/lib/main.js)
After some investigation it seems that templates that attempt to pass parameters to components get the exception. Without parameters we don't get the exception, but nothing is rendered.
Update
I think that I've tracked down the issue. It seems that when you extend
Ember.Application
before create then the initializers are not called.Can be fixed by changing to:
Couldn't find anything in the change log, but if this is an intentional change, maybe it should be documented?
The text was updated successfully, but these errors were encountered: