[BUGFIX beta] Added assert mismatched template compiler version. #3729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See emberjs#3728. Using an old version of Ember to precompile templates can result in an unusual error when trying to render a component in block form, e.g. ``` {{#my-component}}Hello{{/my-component}} ``` This commit adds an assert to give the user more information as to what's going on.
|
/cc @trek |
|
For Handlebars, we have a |
|
I'm gonna do what @wagenet is suggesting |
|
@machty - Do you think the fix you mention will make it into 1.2.0 (current beta)? |
|
I can't see a good hook into Handlebars to perform this check and I don't think we should wait for a Handlebars PR to come through. Reopening, as I think this is probably the best solution so that people at least understand why they're getting trolled. |
|
@rjackson I think it should, waiting on feedback from some more homies. |
This was referenced Nov 16, 2013
machty
added a commit
that referenced
this pull request
Nov 20, 2013
[BUGFIX beta] Added assert mismatched template compiler version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3728. Using an old version of Ember to precompile templates
can result in an unusual error when trying to render a component
in block form, e.g.
This commit adds an assert to give the user more information
as to what's going on.