-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SortableMixin does not work when whole array changes #3706
Comments
Can you create a a JSFiddle or JSBin that demonstrates this problem in isolation? |
Something like this: |
Hmm, that seems odd. @hjdivad, can you chime in here? |
both SortableMixinWhen an item's sort property changes, Em.computed.sort
Fixing SortableMixinFixing
Fixing Em.computed.sort
|
@hjdivad anything actionable here? |
@wagenet yeah I need to fix the two things I listed above for |
just ran into this issue in 1.6.0-beta.5. have you made any progress on this in a branch anywhere @hjdivad ? |
@hjdivad ping. |
any news on this? or workarounds? |
@jwahdatehagh I can't confirm whether it's a fluke or actually a workaround, but I tried this again today and instead of pointing to |
thanks @mlb5000 - i just opted out of this now - using the standard sortProperties option on the model itself with a weird workaround for sorting the properties in different directions now - but everything seems to work so far. |
…rjs#9462, emberjs#4919, emberjs#4231, emberjs#3706, emberjs#5596, emberjs#9485, emberjs#9492, emberjs#5319, emberjs#5268, emberjs#4831, emberjs#5558] Move away from AC/RC instead use the simpler naive enumerable methods, and rely on glimmers stable rendering for efficiency. For more complex scenarios, custom solutions should be used. @wagenet & @stefanpenner
I have an ArrayController of models, whose property which is the sortablePropertie is computed and can change at once, because it is dependent on a single property of another model they all belongTo.
When this happens, every object gets inserted again, but the binary search algorithm does not function properly anymore, because the whole Array became unsorted.
The text was updated successfully, but these errors were encountered: