-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix reduce computed #9492
fix reduce computed #9492
Conversation
This fixes computed properties that depend on other computed properties. Maybe would fix other issues
This is now required in ReduceComputedProperty. Since its not always recomputed on each change. No need do be here anymore
fixes min,max etc
See also #9462 |
Another issue that would be partially fixed: #3706 But the issue could also be fixed by returning This is caused by |
Checking the test cases: From what i read here: http://emberjs.com/api/#method_reduceComputed This is now done with this PR, but not expected in the test. |
…rjs#9462, emberjs#4919, emberjs#4231, emberjs#3706, emberjs#5596, emberjs#9485, emberjs#9492, emberjs#5319, emberjs#5268, emberjs#4831, emberjs#5558] Move away from AC/RC instead use the simpler naive enumerable methods, and rely on glimmers stable rendering for efficiency. For more complex scenarios, custom solutions should be used. @wagenet & @stefanpenner
This fixes computed properties that depend on other computed properties.
issue: #4941
Maybe would fix other issues.
Or introduce more... didnt run the tests yet.
From what i saw through debugging is that
cacheSet
only works ifpropertyDidChange
is not called. It will just be set toundefined
when callingpropertyDidChange
also fixes: #9313
http://emberjs.jsbin.com/hotilafamu/1/edit?html,css,js,console,output
I've made a gist with the fixed code, it can be included in jsbins to test:
https://rawgit.com/patricklx/641946978a1e3bac833d/raw/6f0d5e84db8a5b04939b30350e211e071a378485/reduced-computed-fix.js
currenly there are some problems related to changeMeta