Deprecate ember create keys #11511
Merged
Deprecate ember create keys #11511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rwjblue as per request. Also, unsure if this is labelled correct |
|
👍 - And labeled just fine, thank you! |
| @@ -32,3 +32,14 @@ QUnit.test('SEMVER_REGEX properly validates and invalidates version numbers', fu | |||
| validateVersionString('1.11', false); | |||
| }); | |||
|
|
|||
| QUnit.test('Ember.keys is deprecated', function(){ | |||
There was a problem hiding this comment.
Missing a space after function() here.
stefanpenner
force-pushed
the
deprecate-ember-create-keys
branch
4 times, most recently
from
3eff276
to
e7efd45
Compare
| expectDeprecation(function() { | ||
| Ember.keys({}); | ||
| }, 'Ember.create is deprecated in-favour of Object.create'); | ||
| }) |
There was a problem hiding this comment.
Missing semicolon (causing JSHint failure).
stefanpenner
force-pushed
the
deprecate-ember-create-keys
branch
from
e7efd45
to
d60b750
Compare
rwjblue
force-pushed
the
deprecate-ember-create-keys
branch
from
d60b750
to
1ed73ac
Compare
This was referenced Aug 4, 2015
samselikoff
pushed a commit
to miragejs/ember-cli-mirage
that referenced
this pull request
Aug 11, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.