Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] Fix attributeBindings for id attribute. #11889

Merged
merged 1 commit into from
Jul 25, 2015

Commits on Jul 24, 2015

  1. [BUGFIX release] Fix attributeBindings for id attribute.

    In prior versions of Ember you could customize `id` via
    `attributeBindings` like so:
    
    ```javascript
    export default Ember.Component.extend({
      attributeBindings: [ 'someThing:id' ]
      someThing: 'asdfasdfasdf'
    });
    ```
    
    However, that was broken during the glimmer refactorings because we
    process `attributeBindings` *before* the defaults (meaning the default
    `elementId` is used whenever `id` isn't passed in the template).
    
    This fix is to process the default first, then process `attributeBindings`.
    rwjblue committed Jul 24, 2015
    Configuration menu
    Copy the full SHA
    712227c View commit details
    Browse the repository at this point in the history