Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rollup-app-reexports writes package.json even if not needed #1420

Closed
pieter-v opened this issue May 11, 2023 · 1 comment · Fixed by #1423
Closed

rollup-app-reexports writes package.json even if not needed #1420

pieter-v opened this issue May 11, 2023 · 1 comment · Fixed by #1423
Assignees
@NullVoxPopuli

Comments

@pieter-v
Copy link

We use perforce as a source control system. All files which you are not modifying are read-only.
So the build fails because rollup-app-reexports writes the file package.json even if the result is the same as the original content (https://github.com/embroider-build/embroider/blob/1ecd57ea20195cd54358debde5801f82611d81d1/packages/addon-dev/src/rollup-app-reexports.ts#LL38C19-L38C19)

So, it would be nice if rollup-app-reexports would only write a source file if needed
@NullVoxPopuli NullVoxPopuli self-assigned this May 12, 2023
NullVoxPopuli added a commit to NullVoxPopuli/embroider that referenced this issue May 12, 2023
@NullVoxPopuli
Resolve embroider-build#1420
75e00f9
@NullVoxPopuli NullVoxPopuli mentioned this issue May 12, 2023
Merged
@NullVoxPopuli
Copy link
Collaborator

Thanks for the report @pieter-v !! I put a PR resolving this issue for app-reexports as well as keep-assets

#1423

NullVoxPopuli added a commit to NullVoxPopuli/embroider that referenced this issue May 15, 2023
@NullVoxPopuli
Resolve embroider-build#1420
762a649
NullVoxPopuli added a commit to NullVoxPopuli/embroider that referenced this issue May 17, 2023
@NullVoxPopuli
Resolve embroider-build#1420
e52d42b
NullVoxPopuli added a commit to NullVoxPopuli/embroider that referenced this issue May 18, 2023
@NullVoxPopuli
Resolve embroider-build#1420
aa7d8b8
NullVoxPopuli added a commit to NullVoxPopuli/embroider that referenced this issue May 18, 2023
@NullVoxPopuli
Resolve embroider-build#1420
cc6ecd2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NullVoxPopuli NullVoxPopuli

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@NullVoxPopuli @pieter-v