Do not write package.json when there are no changes (affects addon.appReexports() and addon.publicAssets())
#1423
Conversation
NullVoxPopuli
force-pushed
the
do-not-write-app-re-exports-when-not-needed
branch
from
71416c7
to
4bc6a64
Compare
NullVoxPopuli
changed the title
addon.appReexports() and addon.publicAssets())
NullVoxPopuli
force-pushed
the
do-not-write-app-re-exports-when-not-needed
branch
3 times, most recently
from
139e91f
to
c373485
Compare
NullVoxPopuli
force-pushed
the
do-not-write-app-re-exports-when-not-needed
branch
from
c373485
to
d3a8b31
Compare
|
Working on a test atm -- holding off on merge. |
NullVoxPopuli
force-pushed
the
do-not-write-app-re-exports-when-not-needed
branch
2 times, most recently
from
31070b0
to
f4a926f
Compare
NullVoxPopuli
force-pushed
the
do-not-write-app-re-exports-when-not-needed
branch
from
f4a926f
to
1ef57d6
Compare
| addon.linkDevDependency('rollup', { baseDir: __dirname }); | ||
| }) | ||
| .forEachScenario(scenario => { | ||
| Qmodule(scenario.name, function (hooks) { |
There was a problem hiding this comment.
there are 3 tests here
- 2 watch tests
- 1 re-build
|
|
||
| stop = () => this.#singletonAbort?.abort(); | ||
| settled = () => this.#waitForBuildPromise; | ||
| get lastBuild() { |
There was a problem hiding this comment.
this is the only public api in this class that's not used atm.
I couldn't decide if it would be useful information to have for later.
| // | ||
| // the `stat` is measured in `ms`, so it's still pretty fast | ||
| await aBit(10); | ||
| await fs.rm(path.join(addon.dir, 'src/components/demo.js')); |
There was a problem hiding this comment.
I am very weary of all the ways things can go bad with tests that do file system deletes
I believe for this test renaming a file would be sufficient and less risk prone especially on different OS's
also path.join takes multiple arguments and connects them with the system separator so specifying src comp... as individual parameters will make it a more robust implementation
There was a problem hiding this comment.
path.join takes multiple arguments and connects them with the system separator so specifying src comp..
path.join converts inline separators to the platform-specific separator, if needed.
info here: https://nodejs.org/api/path.html#pathjoinpaths
the key here is that after a path is joined, it's normalized, which does the platform-specific separator fixing.
all the ways things can go bad with tests that do file system deletes
what are those things?
There was a problem hiding this comment.
addon.dir suddenly having a glob like structure that would target more paths than expected.
which can happen outside of changes to this test if you consider something being updated to support/test v2 addons that need to span more folders than just one as it does today
the thought process for me is more on the lines of how to reduce the worst possible case rather than try to avoid something bad from happening
There was a problem hiding this comment.
suddenly having a glob
This would cause a cascade of other problems, too: https://github.com/ef4/scenario-tester/blob/main/index.ts#L185
I've opened embroider-build/scenario-tester#9 to get clarification, and will PR over there depending on the answer.
Resolves #1420
but because app-re-exports isn't the only thing writing to package.json, the same conditional guard was also applied to public-assets.
How to test:
watch -n 1 'stat -f "%Sc" package.json 'brew install watch