Place dark-light behind a feature gate in eframe and egui_glow (#1437)

emilk · Apr 1, 2022 · a52bbad · a52bbad
1 parent 1d32670
commit a52bbad
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,7 @@ NOTE: [`epaint`](epaint/CHANGELOG.md), [`eframe`](eframe/CHANGELOG.md), [`egui_w
 * `ClippedMesh` has been replaced with `ClippedPrimitive` ([#1351](https://github.com/emilk/egui/pull/1351)).
 * Renamed `Frame::margin` to `Frame::inner_margin`.
 * Renamed `AlphaImage` to `FontImage` to discourage any other use for it ([#1412](https://github.com/emilk/egui/pull/1412)).
+* `dark-light` (dark mode detection) is now an opt-in feature for `eframe` and `egui_glow` ([#1437](https://github.com/emilk/egui/pull/1437)).
 
 ### Fixed 🐛
 * Fixed ComboBoxes always being rendered left-aligned ([#1304](https://github.com/emilk/egui/pull/1304)).

diff --git a/eframe/Cargo.toml b/eframe/Cargo.toml
@@ -42,6 +42,8 @@ screen_reader = [
   "egui_web/screen_reader",
 ]
 
+dark-light = [ "egui-winit/dark-light"]              # detect dark mode system preference
+
 
 [dependencies]
 egui = { version = "0.17.0", path = "../egui", default-features = false }

diff --git a/egui_glow/Cargo.toml b/egui_glow/Cargo.toml
@@ -53,6 +53,8 @@ screen_reader = ["egui-winit/screen_reader"]
 # if you want to use glow painter on web disable this feature.
 winit = ["egui-winit", "glutin"]
 
+dark-light = ["egui-winit/dark-light"]                 # detect dark mode system preference
+
 
 [dependencies]
 egui = { version = "0.17.0", path = "../egui", default-features = false, features = [
@@ -67,7 +69,6 @@ tracing = "0.1"
 
 [target.'cfg(not(target_arch = "wasm32"))'.dependencies]
 egui-winit = { version = "0.17.0", path = "../egui-winit", optional = true, default-features = false, features = [
-  "dark-light",
   "epi_backend",
 ] }
 glutin = { version = "0.28.0", optional = true }