Placed dark-light behind a feature gate in eframe and egui_glow #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 30, 2022
|
Thanks - please add a line to |
|
Please also add a link to the relevant |
|
Updated changelog. Relevant issue in dark-light: frewsxcv/rust-dark-light#17 (comment) |
emilk
requested changes
Mar 31, 2022
emilk
approved these changes
Mar 31, 2022
|
Thanks, currently the dark-light failed to build on cross-compiling target. on m1 macos: will error out with dark-light This could be helpful to resolve the issue. |
|
@Piping remember to report |
emilk
added a commit
that referenced
this pull request
Jun 9, 2022
dark-light has a nasty problem on Linux: frewsxcv/rust-dark-light#17 So we made dark-light opt-in in #1437 This PR makes dark-light a default dependency again, but only use it on Max and Windows. This is controlled with the new NativeOptions::follow_system_theme. If this isn't enabled, then NativeOptions::default_theme is used.
emilk
added a commit
that referenced
this pull request
Jun 9, 2022
* Use dark-light on Mac and Windows dark-light has a nasty problem on Linux: frewsxcv/rust-dark-light#17 So we made dark-light opt-in in #1437 This PR makes dark-light a default dependency again, but only use it on Max and Windows. This is controlled with the new NativeOptions::follow_system_theme. If this isn't enabled, then NativeOptions::default_theme is used. * Add eframe::WebOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I placed dark-light behind a feature gate in
eframeandegui_glowbecause of a bug in dark-light that causesdark_light::detect()to block for extended periods of time on some Linux systems. It is not disabled by default, but can be enabled with thedark-lightfeature flag.