made drag and drop support selectable on Windows for the eframe glium integration #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid issues with crates that use multi-threaded COM apis
jnises
changed the title
jnises
commented
Apr 19, 2021
|
|
||
| /// On Windows: enable drag and drop support. | ||
| /// Set to false to avoid issues with crates such as cpal which uses that use multi-threaded COM API <https://github.com/rust-windowing/winit/pull/1524> | ||
| fn drag_and_drop_support(&self) -> bool { |
There was a problem hiding this comment.
perhaps it is better to keep this as a egui_glium-specific setting instead somehow? add arguments to eframe::run_native?
There was a problem hiding this comment.
Yeah, I think this and a few of other things in trait App (is_resizable, icon_data, decorated, and transparent) should be moved to some options that is passed to eframe::run_native, but we can do that in a separate PR
emilk
approved these changes
Apr 19, 2021
|
|
||
| /// On Windows: enable drag and drop support. | ||
| /// Set to false to avoid issues with crates such as cpal which uses that use multi-threaded COM API <https://github.com/rust-windowing/winit/pull/1524> | ||
| fn drag_and_drop_support(&self) -> bool { |
There was a problem hiding this comment.
Yeah, I think this and a few of other things in trait App (is_resizable, icon_data, decorated, and transparent) should be moved to some options that is passed to eframe::run_native, but we can do that in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid issues with crates that use multi-threaded COM apis such as cpal
rust-windowing/winit#1524