Make drag and drop optional (fixes OleInitialize failure #1255) #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Keeping an eye on this, I am patiently waiting to be able to use |
Osspial
suggested changes
Apr 19, 2020
|
Fixed as requested |
|
Any update on this ? Using |
Osspial
reviewed
May 15, 2020
5 tasks
|
Can this be re-reviewed? |
Osspial
approved these changes
Jun 28, 2020
Osspial
force-pushed
the
optional_drag_and_drop
branch
from
506a7dc
to
6e7df74
Compare
3 tasks
maroider
added a commit
to maroider/winit
that referenced
this pull request
Apr 24, 2021
maroider
added a commit
to maroider/winit
that referenced
this pull request
May 3, 2021
francesca64
pushed a commit
that referenced
this pull request
May 4, 2021
vihdzp
added a commit
to vihdzp/winit
that referenced
this pull request
May 5, 2021
Fix incorrect changelog entry for rust-windowing#1524 (rust-windowing#1916)
emilk
pushed a commit
to emilk/egui
that referenced
this pull request
Mar 7, 2022
* Remove warning about cpal drag and drop Given that the issue rust-windowing/winit#1255 was closed by rust-windowing/winit#1524, it would make sense to remove the warning about the issue from NativeOptions * Change `NativeOptions::drag_and_drop_support` default to true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1260 is stalled and based on discussion there I suggest an alternative fix for the
OleInitializeproblem (#1255). This makes drag and drop optional and allowswinitto be used together with libraries likecpalwithout drag and drop functionality. I also improved the panic message as previous was really not informative.cargo fmthas been run on this branchcargo docbuilds successfullyCHANGELOG.mdif knowledge of this change could be valuable to users