Fullscreen

[jeremymeadows]

The default state can be set with the NativeOptions at compile time, and can be changed by using a callback to the UI context during runtime. The fullscreen state is written to the RON file so that the user-set state is restored on each launch.

I added a 'toggle fullscreen' button to the UI too, so that can be previewed.

Closes #662.

[emilk]

Thanks for the PR!

fullscreen is not something that should be part of the egui crate, but instead should be part of the epi::Frame API, just like set_window_size is!

See #672 for how something similar was implemented.

[jeremymeadows]

Got it, sorry I didn’t see that second comment you made on the issue, but I'll see what I can do about moving that around :)

[jeremymeadows]

I got really busy with school stuff and work for several weeks, but finally winding down. I moved those changes around. It was a little tricky to deal with the AppOutput resetting itself every frame; that would undo whatever state was set in the previous frame. I pulled it out to give it slightly broader scope, and I didn't notice any problems it caused.

[emilk]

It was a little tricky to deal with the AppOutput resetting itself every frame

Yeah, it is in need of a refactor.

[emilk]

Any interest in this still?

[antouhou]

@emilk Yes! Is there any way I can help get this merged?

[emilk]

@antouhou Since a lot in this PR is outdated (a lot of epi/eframe refactor), I'm guessing your best bet it so create a new PR from scratch, perhaps with some inspiration taken from this one.