Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

excel2onto: not all relations are included in the generated ontology #457

Closed
jesper-friis opened this issue Sep 3, 2022 · 1 comment · Fixed by #458
Closed

excel2onto: not all relations are included in the generated ontology #457

jesper-friis opened this issue Sep 3, 2022 · 1 comment · Fixed by #458
Assignees
@jesper-friis
Labels
bug Something isn't working

Comments

@jesper-friis
Copy link
Collaborator

jesper-friis commented Sep 3, 2022 •
edited
Loading

@jesper-friis jesper-friis added the bug Something isn't working label Sep 3, 2022
jesper-friis added a commit that referenced this issue Sep 4, 2022
@jesper-friis
Fixed issue #457 by avoiding resetting added_rows for each initial …
22820cc 
…iteration.
@jesper-friis jesper-friis mentioned this issue Sep 4, 2022
Merged
11 tasks
@jesper-friis jesper-friis linked a pull request Sep 4, 2022 that will close this issue
Fixed issue with exel2onto: not all relations are included in the generated ontology #458
Merged
11 tasks
@jesper-friis jesper-friis self-assigned this Sep 4, 2022
@jesper-friis jesper-friis changed the title Issues with excel2onto excel2onto: not all relations are included in the generated ontology Sep 4, 2022
@francescalb
Copy link
Collaborator

Moved the added_rows line back and made a new counter for all_added_rows, including all loops.
The added_rows is used to check if there has been a change to stop a recurring loop, while all_added_rows will make sure that
restrictions are tested for all added rows at the end.

Also, note that there is an error in the excelfile: Microstructure added as concept but MicroStructure used in restrictions for Precipitate. Finally, I assume that you want to use Pore from EMMO, but Pore is not currently defined in the imported EMMO-beta4.

jesper-friis added a commit that referenced this issue Sep 8, 2022
@jesper-friis @francescalb
Fixed issue with exel2onto: not all relations are included in the gen…
499a56b 
…erated ontology (#458)

* Fixed issue #457 by avoiding resetting `added_rows` for each initial iteration.

* Added an extra count for all added rows, including all loops, and fix in property error list.

* Updated ttl file to be made in accordance with correction on restrictions

* Fixed .tll files according to pylint

Co-authored-by: Francesca L. Bleken <francesca.l.bleken@sintef.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jesper-friis jesper-friis

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@jesper-friis @francescalb