Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue with exel2onto: not all relations are included in the generated ontology #458

Merged
merged 7 commits into from
Sep 8, 2022
Merged

Fixed issue with exel2onto: not all relations are included in the generated ontology #458

merged 7 commits into from
Sep 8, 2022

Conversation

jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Sep 4, 2022 •
edited
Loading

Closes #457

Description:

Fixed issue #457 by avoiding resetting added_rows for each initial iteration.

Also made some exception messages little easier to read.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

@jesper-friis jesper-friis linked an issue Sep 4, 2022 that may be closed by this pull request
excel2onto: not all relations are included in the generated ontology #457
Closed
@jesper-friis jesper-friis changed the title Fixed issue with exel2onto Fixed issue with exel2onto: not all relations are included in the generated ontology Sep 4, 2022
@jesper-friis jesper-friis merged commit 499a56b into master Sep 8, 2022
@jesper-friis jesper-friis deleted the 457-issues-with-excel2onto branch September 8, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francescalb francescalb francescalb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

excel2onto: not all relations are included in the generated ontology
2 participants
@jesper-friis @francescalb