Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for userdefined prefixes #439

Merged
merged 23 commits into from
Aug 17, 2022
Merged

Support for userdefined prefixes #439

merged 23 commits into from
Aug 17, 2022

Conversation

francescalb
Copy link
Collaborator

@francescalb francescalb commented Aug 11, 2022 •
edited
Loading

Description:

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

francescalb and others added 21 commits August 11, 2022 10:47
@francescalb
Use prefix as arguemnt instead of namespace in get_by_label
bde56fa 
Changed argument to prefix in get_by_label and get_by_label_all
when only entities from a given ontology with a given prefix are
desired. The prefix is currently being compared to entity._namspace.name
but a solution for prefix should be implemented.
@francescalb
Updated documentation with prefix for get_by_label
8d1215a
@francescalb
Added automatic detection of prefix for the loaded ontology and tests
e84067c
@francescalb
Corrected to that prefix actually cahcek for the prefix of the ontology
cb82c76 
where the entity is from and not the name of the namespace as given in
owldreay2
@francescalb
Added support for get_by_label('prefix:entity')
cf9d7a8
@francescalb
Updated docstring of get_by_label
224fb57
@francescalb
Merge branch 'master' into flb/fix-prefix
ec306e9
@francescalb
Added testonto to fixtures. This revealed a different issue that should
d76b91d 
be adressed separately. Test will fail.
@jesper-friis
Removed dependency on pydot
9ac54f2
@jesper-friis @francescalb
Apply suggestions from code review
063e477 
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
@jesper-friis
Removed pydot from requirements
7989cb6
@jesper-friis
Merge branch 'remove_pydot' into flb/fix-prefix
b0d64d3
@francescalb
Updated so that label_annotations are taken care of even if load is not
ed5686b 
called
@jesper-friis
Merge branch 'flb/fix-prefix' of github.com:emmo-repo/EMMO-python int…
2b21fcc 
…o flb/fix-prefix
@jesper-friis
Removed old test_graph.py
fe6a750
@jesper-friis
Updated Ontology.get_unabbreviated_triples() to match changes in
cb570ac 
World.get_unabbreviated_triples()
@jesper-friis
Changes form pylint and blacken
909a645
@jesper-friis
Removed ontopy/ontograph.py
0a834cc
@jesper-friis
Removed docs for deleted ontograph
b597474
@jesper-friis
Fixed indentation in documentation
381cf0b
@jesper-friis
Typo in docstring
c86679d
@jesper-friis jesper-friis self-requested a review August 17, 2022 15:13
@francescalb francescalb changed the title WIP: support for userdefined prefixes Support for userdefined prefixes Aug 17, 2022
@jesper-friis jesper-friis mentioned this pull request Aug 17, 2022
Merged
11 tasks
@francescalb francescalb merged commit bcfcbfd into master Aug 17, 2022
@francescalb francescalb deleted the flb/fix-prefix branch August 17, 2022 16:14
@francescalb francescalb mentioned this pull request Aug 18, 2022
Closed
@francescalb francescalb mentioned this pull request Aug 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesper-friis jesper-friis jesper-friis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francescalb @jesper-friis