Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue with exel2onto: not all relations are included in the generated ontology #458

Merged
merged 7 commits into from
Sep 8, 2022
Merged

Fixed issue with exel2onto: not all relations are included in the generated ontology #458

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
22820cc
Fixed issue #457 by avoiding resetting `added_rows` for each initial …
jesper-friis Sep 4, 2022
35c51e6
Merge branch 'master' into 457-issues-with-excel2onto
jesper-friis Sep 5, 2022
659389a
Merge branch 'master' into 457-issues-with-excel2onto
francescalb Sep 7, 2022
45a7ed0
Merge branch 'master' into 457-issues-with-excel2onto
francescalb Sep 8, 2022
7128a54
Added an extra count for all added rows, including all loops, and fix…
francescalb Sep 8, 2022
c0867af
Updated ttl file to be made in accordance with correction on
francescalb Sep 8, 2022
74dd06a
Fixed .tll files according to pylint
francescalb Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ontopy/excelparser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,8 @@ def create_ontology_from_pandas( # pylint:disable=too-many-locals,too-many-bran
onto.sync_python_names()
with onto:
remaining_rows = set(range(len(data)))
added_rows = set()
while remaining_rows:
added_rows = set()
for index in remaining_rows:
row = data.loc[index]
name = row["prefLabel"]
Expand Down Expand Up @@ -343,19 +343,19 @@ def create_ontology_from_pandas( # pylint:disable=too-many-locals,too-many-bran
props = properties.split(";")
for prop in props:
try:
concept.is_a.append(evaluate(onto, prop))
concept.is_a.append(evaluate(onto, prop.strip()))
except pyparsing.ParseException as exc:
warnings.warn(
f"Error in Property assignment for: {concept}. "
f"Property to be Evaluated: {prop}. "
f"Error is {exc}."
f"Error in Property assignment for: '{concept}'. "
f"Property to be Evaluated: '{prop}'. "
f"{exc}"
)
concepts_with_errors["errors_in_properties"].append(name)
except NoSuchLabelError as exc:
msg = (
f"Error in Property assignment for: {concept}. "
f"Property to be Evaluated: {prop}. "
f"Error is {exc}."
f"{exc}"
)
if force is True:
warnings.warn(msg)
Expand Down