Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from 'EMMO-python' -> 'EMMOntoPy' #477

Merged
merged 3 commits into from
Oct 4, 2022

Conversation

CasperWA
Copy link
Collaborator

@CasperWA CasperWA commented Oct 4, 2022

Description:

Fixes #476
Fixes #478
Closes #479

The repository name has been changed !!!

This PR updates all repository files that mentions the now old name to the new name, where applicable.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

@CasperWA
Copy link
Collaborator Author

CasperWA commented Oct 4, 2022

Fixed the issue with the pre-commit CI/CD job by using Python 3.8 instead of Python 3.7 in the job.
It seemed to me that this was the issue due to bandit referencing EntryPoints, which has been significantly updated between the two verisons.
Another solution would be to downgrade bandit in the pre-commit hook config file, however, I'd prefer to have the latest version running for these hooks - especially bandit, which tries to find security risks in the code.

All other jobs are still running with Python 3.7 to ensure the package still works with this lowest supported version.

Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx, Casper

@CasperWA CasperWA merged commit 104a8a6 into master Oct 4, 2022
@CasperWA CasperWA deleted the cwa/fix-476-update-repo-name branch October 4, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update repo files with new repo name Pre-commit hook bandit failing Fix publish/release workflow
2 participants