-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncaught ReferenceError: upper is not defined, uuid_unparse #21056
Comments
Thanks for the report. That does looks like serious issue. I was able to reproduce and bistected the issue to #19740. Working on a fix now. |
sbc100
added a commit
to sbc100/emscripten
that referenced
this issue
Jan 10, 2024
When the `__sig` for a function is shorter than the actual number of argument (i.e. when the native signature is shorter than the JS signature) we were dropping the extra arguments in handleI64Signatures. Specifically the `uuid_unparse` library function has a hidden third argument that is not exposed to native code (doesn't appear in the native signature). Fixes: emscripten-core#21056
sbc100
added a commit
to sbc100/emscripten
that referenced
this issue
Jan 10, 2024
When the `__sig` for a function is shorter than the actual number of argument (i.e. when the native signature is shorter than the JS signature) we were dropping the extra arguments in handleI64Signatures. Specifically the `uuid_unparse` library function has a hidden third argument that is not exposed to native code (doesn't appear in the native signature). Fixes: emscripten-core#21056
sbc100
added a commit
to sbc100/emscripten
that referenced
this issue
Jan 10, 2024
When the `__sig` for a function is shorter than the actual number of argument (i.e. when the native signature is shorter than the JS signature) we were dropping the extra arguments in handleI64Signatures. Specifically the `uuid_unparse` library function has a hidden third argument that is not exposed to native code (doesn't appear in the native signature). Fixes: emscripten-core#21056
sbc100
added a commit
to sbc100/emscripten
that referenced
this issue
Jan 10, 2024
When the `__sig` for a function is shorter than the actual number of argument (i.e. when the native signature is shorter than the JS signature) we were dropping the extra arguments in handleI64Signatures. Specifically the `uuid_unparse` library function has a hidden third argument that is not exposed to native code (doesn't appear in the native signature). Fixes: emscripten-core#21056
sbc100
added a commit
to sbc100/emscripten
that referenced
this issue
Jan 11, 2024
When the `__sig` for a function is shorter than the actual number of argument (i.e. when the native signature is shorter than the JS signature) we were dropping the extra arguments in handleI64Signatures. Specifically the `uuid_unparse` library function has a hidden third argument that is not exposed to native code (doesn't appear in the native signature). Fixes: emscripten-core#21056
sbc100
added a commit
that referenced
this issue
Jan 11, 2024
When the `__sig` for a function is shorter than the actual number of argument (i.e. when the native signature is shorter than the JS signature) we were dropping the extra arguments in handleI64Signatures. Specifically the `uuid_unparse` library function has a hidden third argument that is not exposed to native code (doesn't appear in the native signature). Fixes: #21056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please include the following in your bug report:
Version of emscripten/emsdk:
Failing command line in full:
N/A
Full link command and output with
-v
appended:I encountered an error:
Uncaught ReferenceError: upper is not defined
when attempting to load the compiled wasm module. This issue arises from the auto-generated uuid_unparse function, which is missing theupper
argument. The problematic portion of the code looks like this:I noticed that when I compiled using version 3.1.37, the correct function signature includes the
upper
parameter:The text was updated successfully, but these errors were encountered: