Fix dropping of arguments in JS library functions #21062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
avoid_dropping_args
branch
3 times, most recently
from
91cd515 to
f90e0e1
Compare
kripken
approved these changes
Jan 11, 2024
When the `__sig` for a function is shorter than the actual number of argument (i.e. when the native signature is shorter than the JS signature) we were dropping the extra arguments in handleI64Signatures. Specifically the `uuid_unparse` library function has a hidden third argument that is not exposed to native code (doesn't appear in the native signature). Fixes: emscripten-core#21056
sbc100
force-pushed
the
avoid_dropping_args
branch
from
f90e0e1 to
dfdeb79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
__sigfor a function is shorter than the actual number of argument (i.e. when the native signature is shorter than the JS signature) we were dropping the extra arguments in handleI64Signatures.Specifically the
uuid_unparselibrary function has a hidden third argument that is not exposed to native code (doesn't appear in the native signature).Fixes: #21056