-
-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop deprecates #3071
Drop deprecates #3071
Conversation
9ae5b3b
to
4e67f08
Compare
fb8805a
to
3dcc429
Compare
Great. Needs a |
The purpose of this is for v1.0 I thought #3069 will include changelogs. For example for this PR:
@tomchristie Do any docs need to be updated? |
My feeling is that we should push on with 1.0. (Tho I also think that this particular change would be acceptable even in 0.27 release, since it's only removing features that are already formally deprecated.) |
Neat.
For this PR just the |
* Recently deprecated `proxies` argument has been removed. (#3071) | ||
* Per request `cookies` argument is not supporting anymore. (#3071) | ||
* Non-Mapping objects for `data` argument is no longer allowed. (#3071) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest we limit the pull request to just one line item here, and deal with the proxies
case.
Please don't remove per-request cookies :) |
Targeting just the |
I ended up to not drop any public api before major release. |
Summary
version 1.0 proposal
Resolves requirements for #3069 (review)
Checklist