Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pool option warnings for default connection pool #980

Merged
merged 3 commits into from
May 22, 2020
Merged

Fix pool option warnings for default connection pool #980

merged 3 commits into from
May 22, 2020

Conversation

JayH5
Copy link
Member

@JayH5 JayH5 commented May 22, 2020

Currently creating a client with default options on httpx 0.13.0 produces these warnings:

.../lib/python3.8/site-packages/httpx/_utils.py:407
  .../lib/python3.8/site-packages/httpx/_utils.py:407: DeprecationWarning: 'soft_limit' is deprecated. Use 'max_keepalive' instead.
    warnings.warn(message, DeprecationWarning)

.../lib/python3.8/site-packages/httpx/_utils.py:407
  .../lib/python3.8/site-packages/httpx/_utils.py:407: DeprecationWarning: 'hard_limit' is deprecated. Use 'max_connections' instead.
    warnings.warn(message, DeprecationWarning)

@JayH5 JayH5 requested a review from a team May 22, 2020 09:22
@tomchristie
Copy link
Member

Thanks @JayH5!

@tomchristie tomchristie mentioned this pull request May 22, 2020
Merged
@tomchristie tomchristie merged commit e724abd into encode:master May 22, 2020
@JayH5 JayH5 deleted the better-warnings branch May 22, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JayH5 @tomchristie