Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pool option warnings for default connection pool #980

Merged
merged 3 commits into from
May 22, 2020
Merged

Fix pool option warnings for default connection pool #980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae316cf
warn_deprecated: Set stacklevel=2 to get real source of warning
May 22, 2020
5b04cd2
Use new pool limit options in default pool
May 22, 2020
d2e8043
Merge branch 'master' into better-warnings
tomchristie May 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion httpx/_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,5 +367,5 @@ def __repr__(self) -> str:


DEFAULT_TIMEOUT_CONFIG = Timeout(timeout=5.0)
DEFAULT_POOL_LIMITS = PoolLimits(soft_limit=10, hard_limit=100)
DEFAULT_POOL_LIMITS = PoolLimits(max_keepalive=10, max_connections=100)
DEFAULT_MAX_REDIRECTS = 20
2 changes: 1 addition & 1 deletion httpx/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,4 +404,4 @@ def as_network_error(*exception_classes: type) -> typing.Iterator[None]:


def warn_deprecated(message: str) -> None:
warnings.warn(message, DeprecationWarning)
warnings.warn(message, DeprecationWarning, stacklevel=2)