feat(endo): Search for index.js and implied package exports #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the remainder of #401, which I accidentally failed to hoist and squash. |
kriskowal
requested review from
warner and
michaelfig
and removed request for
warner
kriskowal
force-pushed
the
kris/endo-index-leftovers
branch
from
0d8a703
to
50d6fee
Compare
michaelfig
approved these changes
Aug 26, 2020
packages/endo/DESIGN.md
Outdated
|
|
||
| // ExitName is the name of a built-in module, to be threaded in from the | ||
| // modules passed to the module executor. | ||
| type ExitName string; |
There was a problem hiding this comment.
Suggested change
| type ExitName string; | |
| type ExitName = string; |
packages/endo/src/zip.js
Outdated
| @@ -7,9 +7,9 @@ export const readZip = async (data, location) => { | |||
| await zip.loadAsync(data); | |||
| const read = async path => { | |||
| const file = zip.file(path); | |||
| if (file === undefined) { | |||
| if (file === undefined || file === null) { | |||
There was a problem hiding this comment.
Would this be simpler?
Suggested change
| if (file === undefined || file === null) { | |
| if (!file) { |
|
@michaelfig Yeah, I messed something up in this stack so there is duplication here, somehow. |
When asked for a module named "x", Node.js will search for "x.js" then "x/index.js". For packages that do not supply an "exports" property in their "package.json", any module contained by that package is a valid exported module. To achieve parity with these two features, Endo uses different techniques when loading from the file system and loading from an archive. When reading from the file system, Endo will search for a satsifactory candidate in each compartment's asynchronous importHook. Endo also uses the compartment's new moduleMapHook to search for dependency compartments in the "scope" of a module identifier prefix. These allow Endo to operate from an incomplete compartment map for the initial load. The Endo archiver instead creates a more complete compartment map, with every discovered module. This introduces a new kind of module to the compartment map module descriptor type union: modules with known locations and corresponding parsers. The archiver erases the "scopes", "types", and "parsers" on each compartment description since they are no longer necessary. When reading from an archive, Endo uses an importHook that consults the compartment map directly for the locations of all contained modules, and creates a complete moduleMap up front.
kriskowal
force-pushed
the
kris/endo-index-leftovers
branch
from
50d6fee
to
e4d5082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When asked for a module named "x", Node.js will search for "x.js" then "x/index.js".
For packages that do not supply an "exports" property in their "package.json", any module contained by that package is a valid exported module.
To achieve parity with these two features, Endo uses different techniques when loading from the file system and loading from an archive.
When reading from the file system, Endo will search for a satsifactory candidate in each compartment's asynchronous importHook. Endo also uses the compartment's new moduleMapHook to search for dependency compartments in the "scope" of a module identifier prefix. These allow Endo to operate from an incomplete compartment map for the initial load.
The Endo archiver instead creates a more complete compartment map, with every discovered module. This introduces a new kind of module to the compartment map module descriptor type union: modules with known locations and corresponding parsers. The archiver erases the "scopes", "types", and "parsers" on each compartment description since they are no longer necessary.
When reading from an archive, Endo uses an importHook that consults the compartment map directly for the locations of all contained modules, and creates a complete moduleMap up front.