Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(endo): Search for index.js and implied package exports #434

Merged
merged 2 commits into from
Aug 26, 2020
Merged

feat(endo): Search for index.js and implied package exports #434

merged 2 commits into from
Aug 26, 2020

Commits on Aug 26, 2020

  1. feat(endo): Search for index.js and implied package exports 

    When asked for a module named "x", Node.js will search for "x.js" then "x/index.js".

For packages that do not supply an "exports" property in their "package.json", any module contained by that package is a valid exported module.

To achieve parity with these two features, Endo uses different techniques when loading from the file system and loading from an archive.

When reading from the file system, Endo will search for a satsifactory candidate in each compartment's asynchronous importHook.  Endo also uses the compartment's new moduleMapHook to search for dependency compartments in the "scope" of a module identifier prefix.  These allow Endo to operate from an incomplete compartment map for the initial load.

The Endo archiver instead creates a more complete compartment map, with every discovered module.  This introduces a new kind of module to the compartment map module descriptor type union: modules with known locations and corresponding parsers.  The archiver erases the "scopes", "types", and "parsers" on each compartment description since they are no longer necessary.

When reading from an archive, Endo uses an importHook that consults the compartment map directly for the locations of all contained modules, and creates a complete moduleMap up front.
    @kriskowal
    kriskowal committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    df6a2a1 View commit details
    Browse the repository at this point in the history

  2. Address feedback from @michaelfig

    @kriskowal
    kriskowal committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    e4d5082 View commit details
    Browse the repository at this point in the history