Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows image: Upgrade pip and install wheel #56

Merged
merged 1 commit into from
May 12, 2020
Merged

Windows image: Upgrade pip and install wheel #56

merged 1 commit into from
May 12, 2020

Conversation

sunjayBhatia
Copy link
Member

Also ensures pip binary and installed bits are on the PATH

Should fix build issues in: envoyproxy/envoy#11108

Also ensures pip binary and installed bits are on the PATH

Should fix build issues in: envoyproxy/envoy#11108

Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit 9b7dc52 into envoyproxy:master May 12, 2020
@sunjayBhatia sunjayBhatia deleted the windows-pip-install-wheel branch May 12, 2020 16:14
htuch pushed a commit that referenced this pull request May 12, 2020
  [skip ci]
  Upgrade pip and install wheel (#56)

Also ensures pip binary and installed bits are on the PATH

Should fix build issues in: envoyproxy/envoy#11108

Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants