build: add support for pip3_import from rules_python. #11108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide an Envoy build system styled way of loading arbitrary pip3
packages as py_{library,binary} dependencies.
Part of envoyproxy#11085 (to fetch
PyYAML).
Risk level: Low (build system)
Testing: Manual validation that the test utility loads PyYAML at the
correct version (different to my system version).
Signed-off-by: Harvey Tuch <htuch@google.com>
|
seems windows CI is failing? LGTM otherwise |
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
pushed a commit
to envoyproxy/envoy-build-tools
that referenced
this pull request
May 11, 2020
Attempts to fix build issues in: envoyproxy/envoy#11108 Co-authored-by: William A Rowe Jr <wrowe@pivotal.io> Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io> Signed-off-by: William A Rowe Jr <wrowe@pivotal.io> Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
htuch
pushed a commit
to envoyproxy/envoy-build-tools
that referenced
this pull request
May 11, 2020
[skip ci] Windows image: add links for expected python executable names (#51) Attempts to fix build issues in: envoyproxy/envoy#11108 Co-authored-by: William A Rowe Jr <wrowe@pivotal.io> Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io> Signed-off-by: William A Rowe Jr <wrowe@pivotal.io> Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
pushed a commit
to envoyproxy/envoy-build-tools
that referenced
this pull request
May 12, 2020
Also ensures pip binary and installed bits are on the PATH Should fix build issues in: envoyproxy/envoy#11108 Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io> Co-authored-by: William A Rowe Jr <wrowe@pivotal.io> Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io> Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
pushed a commit
to envoyproxy/envoy-build-tools
that referenced
this pull request
May 12, 2020
[skip ci] Upgrade pip and install wheel (#56) Also ensures pip binary and installed bits are on the PATH Should fix build issues in: envoyproxy/envoy#11108 Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io> Co-authored-by: William A Rowe Jr <wrowe@pivotal.io> Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io> Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
|
@lizan this is ready for LGTM/merge. |
|
(and thanks a ton to @wrowe and @sunjayBhatia for helping update the Windows Docker base image!) |
lizan
approved these changes
May 12, 2020
htuch
added a commit
to htuch/envoy
that referenced
this pull request
May 14, 2020
This PR replaces envoyproxy#11058, taking a slightly different approach. We utilize field options to annotate fields that should be set for untrusted environments with [configure_for_untrusted_downstream, configure_for_untrusted_downstream]. Defaults are provided out-of-band, in a manifest files in docs/edge_defaults_manifest.yaml. Protodoc glues the manifest and options together when generating field documentation, providing an additional notice for sensitive fields. This PR depends on envoyproxy#11108 first merging to provide the pip3 build infrastructure. Risk level: Low (docs only). Testing: Inspection of generated docs. Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
added a commit
that referenced
this pull request
May 17, 2020
This PR replaces #11058, taking a slightly different approach. We utilize field options to annotate fields that should be set for untrusted environments with [configure_for_untrusted_downstream, configure_for_untrusted_downstream]. Defaults are provided out-of-band, in a manifest files in docs/edge_defaults_manifest.yaml. Protodoc glues the manifest and options together when generating field documentation, providing an additional notice for sensitive fields. This PR depends on #11108 first merging to provide the pip3 build infrastructure. Risk level: Low (docs only). Testing: Inspection of generated docs. Signed-off-by: Harvey Tuch <htuch@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide an Envoy build system styled way of loading arbitrary pip3
packages as py_{library,binary} dependencies.
Part of #11085 (to fetch
PyYAML).
Risk level: Low (build system)
Testing: Manual validation that the test utility loads PyYAML at the
correct version (different to my system version).
Signed-off-by: Harvey Tuch htuch@google.com