Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android: App lifecycle & network condition handling #129

Closed
rebello95 opened this issue Jun 17, 2019 · 1 comment
Closed

android: App lifecycle & network condition handling #129

rebello95 opened this issue Jun 17, 2019 · 1 comment
Assignees
@buildbreaker
Labels
platform/android Issues related to Android
Milestone
v0.2 "Primo"

Comments

@rebello95
Copy link
Contributor

  • Envoy Mobile will need to be aware of certain application lifecycle events (such as backgrounding/foregrounding, termination, etc.) in order to appropriately shut down connections, restart, or tell the OS that the app has requests in flight while it’s backgrounded.
  • These should be handled entirely by the native Envoy Mobile layers, and will likely perform the following tasks:
  • Upon instantiation/startup, begin observing application-level lifecycle events
    React to changes by restarting Envoy core - shutting down connections, etc. as necessary
  • Ensure that the Envoy core is able to make requests when the app is backgrounded

Google doc reference here.
iOS issue: #128
@rebello95 rebello95 added the platform/android Issues related to Android label Jun 17, 2019
@rebello95 rebello95 added this to the v0.2 "Primo" milestone Jun 17, 2019
@rebello95 rebello95 mentioned this issue Jun 17, 2019
Closed
@rebello95 rebello95 changed the title android: App lifecycle handling android: App lifecycle & network condition handling Jun 17, 2019
@buildbreaker buildbreaker mentioned this issue Jun 21, 2019
Merged
buildbreaker pushed a commit that referenced this issue Jun 25, 2019
android: Update examples to display errors with a red background (#166)
a5916eb 
This is just a change to allow us to more easily visualize when Envoy fails. We're repurposing the examples here to also display this. This way others can also install the example application and be able to visualize the success/failures of Envoy in the wild.

Changes:
1. An error view item background is: #ff3651
1. Added a request count on the top of the item view (Screen below)
1. Moved all the duplicated classes for java and kotlin examples under a shared lib

Related to #129: App lifecycle & network condition handling.
For an explanation of how to fill out the fields, please see the relevant section
in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md)

Description: Update examples to display errors with a red background
Risk Level: low
Testing: manual
Docs Changes: n/a
Release Notes: na/
[Optional Fixes #Issue]
[Optional Deprecated:]

![Screenshot_20190621-164638](https://user-images.githubusercontent.com/7771562/59956309-74d03580-9444-11e9-8c0e-9c73c9beddc1.png)
@stale
Copy link

stale bot commented Jul 18, 2019

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 18, 2019
@junr03 junr03 removed the stale label Sep 6, 2019
jpsim pushed a commit to envoyproxy/envoy that referenced this issue Nov 28, 2022
@jpsim
android: Update examples to display errors with a red background (#166)
4ab6fd4 
This is just a change to allow us to more easily visualize when Envoy fails. We're repurposing the examples here to also display this. This way others can also install the example application and be able to visualize the success/failures of Envoy in the wild.

Changes:
1. An error view item background is: #ff3651
1. Added a request count on the top of the item view (Screen below)
1. Moved all the duplicated classes for java and kotlin examples under a shared lib

Related to envoyproxy/envoy-mobile#129: App lifecycle & network condition handling.
For an explanation of how to fill out the fields, please see the relevant section
in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md)

Description: Update examples to display errors with a red background
Risk Level: low
Testing: manual
Docs Changes: n/a
Release Notes: na/
[Optional Fixes #Issue]
[Optional Deprecated:]

![Screenshot_20190621-164638](https://user-images.githubusercontent.com/7771562/59956309-74d03580-9444-11e9-8c0e-9c73c9beddc1.png)

Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit to envoyproxy/envoy that referenced this issue Nov 29, 2022
@jpsim
android: Update examples to display errors with a red background (#166)
8dd2750 
This is just a change to allow us to more easily visualize when Envoy fails. We're repurposing the examples here to also display this. This way others can also install the example application and be able to visualize the success/failures of Envoy in the wild.

Changes:
1. An error view item background is: #ff3651
1. Added a request count on the top of the item view (Screen below)
1. Moved all the duplicated classes for java and kotlin examples under a shared lib

Related to envoyproxy/envoy-mobile#129: App lifecycle & network condition handling.
For an explanation of how to fill out the fields, please see the relevant section
in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md)

Description: Update examples to display errors with a red background
Risk Level: low
Testing: manual
Docs Changes: n/a
Release Notes: na/
[Optional Fixes #Issue]
[Optional Deprecated:]

![Screenshot_20190621-164638](https://user-images.githubusercontent.com/7771562/59956309-74d03580-9444-11e9-8c0e-9c73c9beddc1.png)

Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@buildbreaker buildbreaker

Labels
platform/android Issues related to Android
Projects
None yet
Milestone
v0.2 "Primo"
Development

No branches or pull requests
3 participants
@rebello95 @junr03 @buildbreaker