android: Update examples to display errors with a red background #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 21, 2019 15:50
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
goaway
reviewed
Jun 22, 2019
goaway
reviewed
Jun 22, 2019
Signed-off-by: Alan Chiu <achiu@lyft.com>
rebello95
added a commit
that referenced
this pull request
Jun 27, 2019
Update the Swift and Objective-C demos to follow the UI logic implemented by #166. Resolves #168.  Signed-off-by: Michael Rebello <mrebello@lyft.com>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 28, 2022
Update the Swift and Objective-C demos to follow the UI logic implemented by envoyproxy/envoy-mobile#166. Resolves envoyproxy/envoy-mobile#168.  Signed-off-by: Michael Rebello <mrebello@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 29, 2022
Update the Swift and Objective-C demos to follow the UI logic implemented by envoyproxy/envoy-mobile#166. Resolves envoyproxy/envoy-mobile#168.  Signed-off-by: Michael Rebello <mrebello@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a change to allow us to more easily visualize when Envoy fails. We're repurposing the examples here to also display this. This way others can also install the example application and be able to visualize the success/failures of Envoy in the wild.
Changes:
Related to #129: App lifecycle & network condition handling.
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: Update examples to display errors with a red background
Risk Level: low
Testing: manual
Docs Changes: n/a
Release Notes: na/
[Optional Fixes #Issue]
[Optional Deprecated:]