Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS docs do not mention that the subject alt name is not verified by default #7312

Closed
jeid64 opened this issue Jun 18, 2019 · 1 comment · Fixed by #8678
Closed

TLS docs do not mention that the subject alt name is not verified by default #7312

jeid64 opened this issue Jun 18, 2019 · 1 comment · Fixed by #8678
Assignees
Labels
Milestone

Comments

@jeid64
Copy link

jeid64 commented Jun 18, 2019

Title: TLS docs do not mention that the subject alt name is not verified by default

Description:
https://www.envoyproxy.io/docs/envoy/v1.8.0/intro/arch_overview/ssl#enabling-certificate-verification
The documentation is a little confusing and leads people to believe that if they only enable trusted_ca, they'll actually be verifying the alternative name on the cert.

See:
"/etc/ssl/certs/ca-certificates.crt is the default path for the system CA bundle on Debian systems. This makes Envoy verify the server identity of 127.0.0.2:1234 in the same way as e.g. cURL does on standard Debian installations."
from https://www.envoyproxy.io/docs/envoy/v1.8.0/intro/arch_overview/ssl#enabling-certificate-verification

However, the default behavior for curl is to verify that the subject name matches the DNS name connected to, which this example does not. Instead, it's only verifying that the cert presented can be validated against the entire Debian CA bundle. I think the example should be updated to add verify_subject_alt_name and mention that otherwise anyone can present any publicly signed cert and Envoy will accept it.

@mattklein123 mattklein123 added the help wanted Needs help! label Jun 18, 2019
@mattklein123
Copy link
Member

Agreed we can/should do better here. Doc PRs appreciated to add warnings, links, etc.

@mattklein123 mattklein123 added this to the 1.12.0 milestone Jul 3, 2019
@mattklein123 mattklein123 self-assigned this Oct 10, 2019
mattklein123 added a commit that referenced this issue Oct 19, 2019
Fixes #8190
Fixes #7420
Fixes #7331
Fixes #7312
Fixes #7284

Signed-off-by: Matt Klein <mklein@lyft.com>
mattklein123 added a commit that referenced this issue Oct 21, 2019
Fixes #8190
Fixes #7420
Fixes #7331
Fixes #7312
Fixes #7284

Signed-off-by: Matt Klein <mklein@lyft.com>
mattklein123 pushed a commit to envoyproxy/data-plane-api that referenced this issue Oct 21, 2019
Fixes envoyproxy/envoy#8190
Fixes envoyproxy/envoy#7420
Fixes envoyproxy/envoy#7331
Fixes envoyproxy/envoy#7312
Fixes envoyproxy/envoy#7284

Signed-off-by: Matt Klein <mklein@lyft.com>

Mirrored from https://github.com/envoyproxy/envoy @ 8e0b240b0e0abcda07b7b259178bdad60a699019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants