-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: misc doc debt #8678
docs: misc doc debt #8678
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements! A couple of questions..
of the :ref:`HttpConnectionManager | ||
<envoy_api_msg_config.filter.network.http_connection_manager.v2.HttpConnectionManager>` config. | ||
|
||
.. http:post:: /envoy.api.v2.ScopedRoutesDiscoveryService/StreamScopedRoutes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to switch to using protodoc for service documentation? These seem more like pseudo-REST than gRPC..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is tracked in #3091. I agree this should all be auto generated, but I was just trying to get us to parity for now.
Signed-off-by: Matt Klein <mklein@lyft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you so much for tackling these!
@htuch @alyssawilk updated |
Fixes #8190
Fixes #7420
Fixes #7331
Fixes #7312
Fixes #7284