Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: misc doc debt #8678

Merged
merged 3 commits into from
Oct 21, 2019
Merged

docs: misc doc debt #8678

merged 3 commits into from
Oct 21, 2019

Conversation

mattklein123
Copy link
Member

Fixes #8190
Fixes #7420
Fixes #7331
Fixes #7312
Fixes #7284

Fixes #8190
Fixes #7420
Fixes #7331
Fixes #7312
Fixes #7284

Signed-off-by: Matt Klein <mklein@lyft.com>
@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #8678 was opened by mattklein123.

see: more, trace.

Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements! A couple of questions..

of the :ref:`HttpConnectionManager
<envoy_api_msg_config.filter.network.http_connection_manager.v2.HttpConnectionManager>` config.

.. http:post:: /envoy.api.v2.ScopedRoutesDiscoveryService/StreamScopedRoutes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to switch to using protodoc for service documentation? These seem more like pseudo-REST than gRPC..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is tracked in #3091. I agree this should all be auto generated, but I was just trying to get us to parity for now.

docs/root/faq/configuration/timeouts.rst Show resolved Hide resolved
Signed-off-by: Matt Klein <mklein@lyft.com>
Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much for tackling these!

docs/root/faq/configuration/timeouts.rst Show resolved Hide resolved
docs/root/faq/configuration/timeouts.rst Outdated Show resolved Hide resolved
docs/root/faq/configuration/timeouts.rst Outdated Show resolved Hide resolved
docs/root/intro/arch_overview/listeners/listeners.rst Outdated Show resolved Hide resolved
Signed-off-by: Matt Klein <mklein@lyft.com>
@mattklein123
Copy link
Member Author

@htuch @alyssawilk updated

@mattklein123 mattklein123 merged commit 8e0b240 into master Oct 21, 2019
@mattklein123 mattklein123 deleted the doc_fixes branch October 21, 2019 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants