devex: initial commit of devcontainer setup #11207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
htuch
suggested changes
May 14, 2020
|
|
||
| ## How to use | ||
|
|
||
| Open with VSCode with the Container extension installed. Follow the [official guide](https://code.visualstudio.com/docs/remote/containers) to open this |
There was a problem hiding this comment.
Can you be a bit more precise in wording here. I think it's the Remote - Containers extension.
| GCP_SERVICE_ACCOUNT_KEY=<base64 encoded service account key> | ||
| BAZEL_REMOTE_INSTANCE=<RBE Instance> | ||
| BAZEL_REMOTE_CACHE=grpcs://remotebuildexecution.googleapis.com | ||
| BAZEL_BUILD_EXTRA_OPTIONS=--config=remote-ci --config=remote --jobs=<Number of jobs> |
There was a problem hiding this comment.
Is it worth diving into download minimal vs. all here? I think that can make a huge difference if you are sitting behind a cable modem connection vs. same region GCP?
snowp
reviewed
May 15, 2020
| ### Disk performance | ||
|
|
||
| Docker for Mac/Windows is known to have disk performance issue, this makes formatting all files in the container very slow. | ||
| [Update the mount consistency to 'delegated'](https://code.visualstudio.com/docs/remote/containers-advanced#_update-the-mount-consistency-to-delegated-for-macos) is recommended. |
There was a problem hiding this comment.
I think the mount consistency option is a noop for linux, so should this just be enabled by default?
There was a problem hiding this comment.
This goes to user's settings.json so I don't have any way to enable it by default.
There was a problem hiding this comment.
There is a workspaceMount option you can set on devcontainer.json, but maybe we don't want to mess with the mount options by default.
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
htuch
reviewed
May 18, 2020
|
|
||
| tools/proto_format/proto_format.sh fix | ||
|
|
||
| # Setting platform suffix here so the compdb headers won't be overwritten by another bazel run |
There was a problem hiding this comment.
As discussion on Slack, probably worth some warnings on what needs to be done when doing API work in this environment.
There was a problem hiding this comment.
spenceral
added a commit
to spenceral/envoy
that referenced
this pull request
May 20, 2020
Signed-off-by: Spencer Lewis <slewis@squareup.com> * master: (33 commits) docs: break release notes into categories (envoyproxy#11217) admin: extract more handlers to separate classes (envoyproxy#11258) Load reporting service documentation (envoyproxy#10962) http: testing 304-with-body behavior (envoyproxy#11261) fixing typos and breaking link issues (envoyproxy#11270) devex: initial commit of devcontainer setup (envoyproxy#11207) security: update policy for fix/disclosure SLOs. (envoyproxy#11243) http: fixing CONNECT to not advertise chunk encoding. (envoyproxy#11245) docs: update upstream network filters description (envoyproxy#11231) deps: update datadog tracer to v1.1.5 (envoyproxy#11253) test: Fix missing instantiation of parameterized tests. (envoyproxy#11247) fix go mirror when no changes (envoyproxy#11249) docs: host_rewrite -> host_rewrite_literal (envoyproxy#11229) wasm: update V8 to v8.3.110.9. (envoyproxy#11233) tls: update BoringSSL to 107c03cf (4103). (envoyproxy#11232) bazelci: always exclude nocoverage tag in coverage config (envoyproxy#11226) ci: save api revision in go-control-plane (envoyproxy#11220) build: fix cares build (envoyproxy#11225) stats: Pre-allocate codec stats for http1 and http2 (envoyproxy#11135) api: manifest based edge default documentation. (envoyproxy#11151) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risk Level: Low (not affecting any output)
Testing: local
Docs Changes:
.devcontainer/README.mdRelease Notes: N/A
Signed-off-by: Lizan Zhou lizan@tetrate.io