Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update upstream network filters description #11231

Merged

Conversation

rebrendov
Copy link
Contributor

@rebrendov rebrendov commented May 17, 2020

Signed-off-by: Tsimafei Bredau timofei.bredov@gmail.com

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Commit Message: update upstream network filters description to reflect availability of upstream filters
Additional Description: made documentation more clear on what upstream filters are currently available and removed a link to a list of network level filters, to avoid confusion
Risk Level: Low
Testing: ran a format checker with git push hook
Docs Changes: in description of upstream filters made more clear that no upstream filters are available in current version of envoy according to #11015 and #10525
Release Notes: N/A
Fixes #11015

Signed-off-by: Tsimafei Bredau <timofei.bredov@gmail.com>
@rebrendov rebrendov force-pushed the update-upstream-filters-docs branch from 1f0131e to 622a1d0 Compare May 17, 2020 17:36
@jmarantz
Copy link
Contributor

Also, please never force-push in Envoy github development. It makes reviewing very difficult.

Use normal push.

Signed-off-by: Tsimafei Bredau <timofei.bredov@gmail.com>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks one small comment.

/wait

Signed-off-by: Tsimafei Bredau <timofei.bredov@gmail.com>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 reopened this May 19, 2020
@mattklein123 mattklein123 merged commit b86e0a7 into envoyproxy:master May 19, 2020
@rebrendov rebrendov deleted the update-upstream-filters-docs branch May 19, 2020 19:47
spenceral added a commit to spenceral/envoy that referenced this pull request May 20, 2020
Signed-off-by: Spencer Lewis <slewis@squareup.com>

* master: (33 commits)
  docs: break release notes into categories (envoyproxy#11217)
  admin: extract more handlers to separate classes  (envoyproxy#11258)
  Load reporting service documentation  (envoyproxy#10962)
  http: testing 304-with-body behavior (envoyproxy#11261)
  fixing typos and breaking link issues (envoyproxy#11270)
  devex: initial commit of devcontainer setup (envoyproxy#11207)
  security: update policy for fix/disclosure SLOs. (envoyproxy#11243)
  http: fixing CONNECT to not advertise chunk encoding. (envoyproxy#11245)
  docs: update upstream network filters description (envoyproxy#11231)
  deps: update datadog tracer to v1.1.5 (envoyproxy#11253)
  test: Fix missing instantiation of parameterized tests. (envoyproxy#11247)
  fix go mirror when no changes (envoyproxy#11249)
  docs: host_rewrite -> host_rewrite_literal (envoyproxy#11229)
  wasm: update V8 to v8.3.110.9. (envoyproxy#11233)
  tls: update BoringSSL to 107c03cf (4103). (envoyproxy#11232)
  bazelci: always exclude nocoverage tag in coverage config (envoyproxy#11226)
  ci: save api revision in go-control-plane (envoyproxy#11220)
  build: fix cares build (envoyproxy#11225)
  stats: Pre-allocate codec stats for http1 and http2 (envoyproxy#11135)
  api: manifest based edge default documentation. (envoyproxy#11151)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify what network filters can be used as upstream filters
3 participants