-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ratelimit: add route entry metadata to ratelimit actions #13269
ratelimit: add route entry metadata to ratelimit actions #13269
Conversation
Modifies ratelimit filter to be able to use information from the route's filter metadata as one of its actions Signed-off-by: András Czigány <andras.czigany@strivacity.com>
Signed-off-by: András Czigány <andras.czigany@strivacity.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/wait
Signed-off-by: András Czigány <andras.czigany@strivacity.com>
…data-ratelimit-action Signed-off-by: András Czigány <andras.czigany@strivacity.com>
Signed-off-by: András Czigány <andras.czigany@strivacity.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, a few comments
/wait |
Signed-off-by: András Czigány <andras.czigany@strivacity.com>
…data-ratelimit-action Signed-off-by: András Czigány <andras.czigany@strivacity.com>
Signed-off-by: András Czigány <andras.czigany@strivacity.com>
Signed-off-by: András Czigány <andras.czigany@strivacity.com>
…data-ratelimit-action Signed-off-by: András Czigány <andras.czigany@strivacity.com>
Signed-off-by: András Czigány <andras.czigany@strivacity.com>
Signed-off-by: András Czigány <andras.czigany@strivacity.com>
Signed-off-by: András Czigány <andras.czigany@strivacity.com>
Signed-off-by: András Czigány <andras.czigany@strivacity.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One API question. Thank you!
/wait-any
…data-ratelimit-action Signed-off-by: András Czigány <andras.czigany@strivacity.com>
…data-ratelimit-action Signed-off-by: András Czigány <andras.czigany@strivacity.com>
Signed-off-by: András Czigány <andras.czigany@strivacity.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks looks great. Just one small comment.
/wait
Signed-off-by: András Czigány <andras.czigany@strivacity.com>
Signed-off-by: András Czigány <andras.czigany@strivacity.com>
Signed-off-by: András Czigány <andras.czigany@strivacity.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
* master: (22 commits) delay health checks until transport socket secrets are ready. (envoyproxy#13516) test, oauth2: Make sure config test runs field validation (envoyproxy#13496) [http] swap codec implementations to default new (envoyproxy#13579) wasm: update proxy-wasm-cpp-host (envoyproxy#13606) postgres: do not copy and linearize received data when it is not going to be used (envoyproxy#13393) configs: Update configs v2 -> v3 (envoyproxy#13562) http2: Remove RELEASE_ASSERTs in sendPendingFrames() error handling (envoyproxy#13546) dependencies: track untracked implied dependencies, wrapup dashboard. (envoyproxy#13571) listener: add match all filter chain (envoyproxy#13449) fix mistakes in docstrings (envoyproxy#13603) ratelimit: add route entry metadata to ratelimit actions (envoyproxy#13269) cluster manager: avoid immediate activation for dynamic inserted cluster when initialize (envoyproxy#12783) ext_authz: Avoid calling check multiple times (envoyproxy#13288) docs: Unexclude remaining configs from validation (envoyproxy#13534) build: update rules_rust to allow Rustc in RBE (envoyproxy#13595) docs: Update sphinxext.rediraffe (envoyproxy#13589) Deprecate moonjit support on Windows before beta (envoyproxy#13541) dependencies: bump LuaJIT to 2.1 branch HEAD @ e9af1ab. (envoyproxy#13474) docs: add TLS stats to cluster stats doc (envoyproxy#13561) ci: stop building alpine-debug images in favor of ubuntu-based debug image (envoyproxy#13598) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Commit Message: Modifies ratelimit filter to be able to use information
from the route's filter metadata as one of its actions with a route_entry_metadata action
configurable the same way as dynamic_metadata
Signed-off-by: András Czigány andras.czigany@strivacity.com
Additional Description:
Risk Level: Low
Testing: unit tests
Docs Changes: proto files and current version changelog
Release Notes: N/A see docs changes
Fixes #12556
edit: filter_metadata -> route_entry_metadata