Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: track untracked implied dependencies, wrapup dashboard. #13571

Merged
merged 5 commits into from
Oct 16, 2020
Merged

dependencies: track untracked implied dependencies, wrapup dashboard. #13571

merged 5 commits into from
Oct 16, 2020

Conversation

htuch
Copy link
Member

@htuch htuch commented Oct 14, 2020

A few changes that wrapup #12673.

  • Python/Go dependencies that aren't part of the Envoy binary build
    don't make sense to track in repository_locations.bzl, since they
    have their own language specific metadata (e.g. requirements.txt)
    or are in many cases transitively implied.

  • Ensure that the full set of dependencies visible to bazel query
    is now validated. This requires that we explicitly call out
    transitive dependencies that are implied by direct dependencies
    in repository_locations.bzl. A new annotation implied_untracked_deps
    is used.

Fixes #12673

Risk level: Low
Testing: validate.py.

Signed-off-by: Harvey Tuch htuch@google.com

@htuch
dependencies: track untracked implied dependencies, wrapup dashboard.
5958383 
A few changes that wrapup envoyproxy#12673.

* Python/Go dependencies that aren't part of the Envoy binary build
  don't make sense to track in repository_locations.bzl, since they
  have their own language specific metadata (e.g. requirements.txt)
  or are in many cases transitively implied.

* Ensure that the full set of dependencies visible to bazel query
  is now validated. This requires that we explicitly call out
  transitive dependencies that are implied by direct dependencies
  in repository_locations.bzl. A new annotation `implied_untracked_deps`
  is used.

Fixes envoyproxy#12673

Risk level: Low
Testing: validate.py.

Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch htuch requested a review from moderation October 14, 2020 13:54
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 14, 2020
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt).

🐱

Caused by: #13571 was opened by htuch.

see: more, trace.

asraa
asraa reviewed Oct 15, 2020
View reviewed changes
Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I personally think last_updated makes more sense as the time of the last commit/release, but I believe that means some dates should be changed

tools/dependency/validate.py Show resolved Hide resolved
tools/dependency/validate.py Show resolved Hide resolved
@moderation
Copy link
Contributor

Thanks! I personally think last_updated makes more sense as the time of the last commit/release, but I believe that means some dates should be changed

That is the plan @asraa. Harvey linked to the new PR where we switch from last_updated to release_date and make it refer to last commit / release time as you suggest.

asraa
asraa approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@htuch
Copy link
Member Author

htuch commented Oct 16, 2020

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Oct 16, 2020
@htuch htuch merged commit 499f46a into envoyproxy:master Oct 16, 2020
@htuch htuch deleted the dep-next-2 branch October 16, 2020 16:45
mpuncel added a commit to mpuncel/envoy that referenced this pull request Oct 17, 2020
@mpuncel
Merge branch 'master' into mpuncel/http2-hc-goaway
b76c46e 
* master: (22 commits)
  delay health checks until transport socket secrets are ready. (envoyproxy#13516)
  test, oauth2: Make sure config test runs field validation (envoyproxy#13496)
  [http] swap codec implementations to default new (envoyproxy#13579)
  wasm: update proxy-wasm-cpp-host (envoyproxy#13606)
  postgres: do not copy and linearize received data when it is not going to be used (envoyproxy#13393)
  configs: Update configs v2 -> v3 (envoyproxy#13562)
  http2: Remove RELEASE_ASSERTs in sendPendingFrames() error handling (envoyproxy#13546)
  dependencies: track untracked implied dependencies, wrapup dashboard. (envoyproxy#13571)
  listener: add match all filter chain (envoyproxy#13449)
  fix mistakes in docstrings (envoyproxy#13603)
  ratelimit: add route entry metadata to ratelimit actions (envoyproxy#13269)
  cluster manager: avoid immediate activation for dynamic inserted cluster when initialize (envoyproxy#12783)
  ext_authz: Avoid calling check multiple times (envoyproxy#13288)
  docs: Unexclude remaining configs from validation (envoyproxy#13534)
  build: update rules_rust to allow Rustc in RBE (envoyproxy#13595)
  docs: Update sphinxext.rediraffe (envoyproxy#13589)
  Deprecate moonjit support on Windows before beta (envoyproxy#13541)
  dependencies: bump LuaJIT to 2.1 branch HEAD @ e9af1ab. (envoyproxy#13474)
  docs: add TLS stats to cluster stats doc (envoyproxy#13561)
  ci: stop building alpine-debug images in favor of ubuntu-based debug image (envoyproxy#13598)
  ...

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
@phlax phlax mentioned this pull request Aug 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moderation moderation moderation left review comments

@asraa asraa asraa approved these changes

Assignees

@asraa asraa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance external dependency documentation
3 participants
@htuch @moderation @asraa