examples: Add dynamic configuration (control plane) sandbox #13746
Conversation
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
examples-dynamic-configuration
branch
from
8defbe4
to
0e98260
Compare
| [ | ||
| { | ||
| "cluster": { | ||
| "@type": "type.googleapis.com/envoy.api.v2.Cluster", |
There was a problem hiding this comment.
this is the wrong response - update to v3
There was a problem hiding this comment.
hmm - seems like this is the response you get back from the go-control-plane
There was a problem hiding this comment.
i guess this must be what is configured in static_resources - im surprised its not an api.v3.Cluster
There was a problem hiding this comment.
Yeah I would update to v3 if possible. cc @htuch @kyessenov for guidance here.
There was a problem hiding this comment.
this seems like an issue with go-control-plane - (at least the example i based this on)
There was a problem hiding this comment.
hmm, i reckon its not gcp thats returning this, its what you get from config above, when you do config_dump in envoy - its the static part
There was a problem hiding this comment.
OK not sure what the issue is without digging in more detail. It's possible this is a config dump issue. I'm not sure.
There was a problem hiding this comment.
let me open a ticket - and we can thrash it out there...
There was a problem hiding this comment.
@phlax Can you help me with the gcp samples you followed? From the initial pass looks like gcp example uses v3 https://github.com/envoyproxy/go-control-plane/blob/master/internal/example/README.md
There was a problem hiding this comment.
@jyotimahapatra i think its not a problem with go-control-plane
i opened a ticket here #13817 to raise it
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
changed the title
|
@mattklein123 ive finished updating - i think it should be ready for final review not sure about #13746 (comment) but i reckon its beyond the scope of this PR im happy to follow up |
* master: (83 commits) tls: Typesafe tls slots (envoyproxy#13789) docs(example): Correct URL for caching example page (envoyproxy#13810) [fuzz] Made health check fuzz more efficient (envoyproxy#13747) rtds: properly scope rtds stats (envoyproxy#13764) http: fixing a bug with IPv6 hosts (envoyproxy#13798) connection: Remember transport socket read resumption requests and replay them when re-enabling read. (envoyproxy#13772) network: adding some accessors for ALPN work. (envoyproxy#13785) docs: added a step about how to handle platform specific extensions (envoyproxy#13759) Fix identation in ip transparency code snippet (envoyproxy#13743) wasm: enable WAVM's stack unwinding feature (envoyproxy#13792) log: set route name for direct response (envoyproxy#13683) Use nghttp2 as external dependsncy in protocol_constraints_lib (envoyproxy#13763) [Windows] Update windows dev docs (envoyproxy#13741) cel: patch thread safety issue (envoyproxy#13739) Windows: Fix ssl_socket_test (envoyproxy#13264) apple dns: add fake api test suite (envoyproxy#13780) overload: scale selected timers in response to load (envoyproxy#13475) examples: Add dynamic configuration (control plane) sandbox (envoyproxy#13746) Removed exception in getResponseStatus() (envoyproxy#13314) network: add timeout for transport connect (envoyproxy#13610) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: examples: Add control plane dynamic configuration sandbox
Additional Description:
Add example of using dynamic configuration with go-control-plane
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]