examples: Add dynamic configuration (filesystem) sandbox #13783
Conversation
phlax
changed the title
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
examples-fs-dynamic-configuration
branch
from
da85a34
to
447ba10
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
examples-fs-dynamic-configuration
branch
from
447ba10
to
d54bdc7
Compare
|
docs are here - http://storage.googleapis.com/envoy-pr/13783/docs/start/sandboxes/dynamic-configuration-filesystem.html its still pretty wip |
Signed-off-by: Ryan Northey <ryan@synca.io>
|
|
||
| .. note:: | ||
|
|
||
| If you are running on a system with strict ``umask`` you will need to ``chmod`` the dynamic config |
There was a problem hiding this comment.
im not over-happy with this, but after thinking about it quite a bit, it seems like the least bad option to handle the umask issue
| $ curl -s http://localhost:10000 | ||
| Request served by service1 | ||
|
|
||
| HTTP/2.0 GET / |
There was a problem hiding this comment.
im confused as to why this is getting HTTP/2.0 but the control plane sandbox, didnt
| @@ -18,6 +18,7 @@ filegroup( | |||
| ], | |||
| exclude = [ | |||
| "cache/responses.yaml", | |||
| "dynamic-config-fs/**/*", | |||
There was a problem hiding this comment.
this isnt ideal, but theres not an obvious way to include the dynamic yaml without it being treated as a standalone envoy config
at least this config gets tested in the sandbox
There was a problem hiding this comment.
Hmm yeah. I think we could probably config check these separately somehow but not a huge deal for now.
phlax
changed the title
|
/retest |
|
Retrying Azure Pipelines: |
Signed-off-by: Ryan Northey <ryan@synca.io>
|
this one should be ready for final review |
| $ curl -s http://localhost:10000 | ||
| Request served by service1 | ||
|
|
||
| HTTP/2.0 GET / |
| @@ -18,6 +18,7 @@ filegroup( | |||
| ], | |||
| exclude = [ | |||
| "cache/responses.yaml", | |||
| "dynamic-config-fs/**/*", | |||
There was a problem hiding this comment.
Hmm yeah. I think we could probably config check these separately somehow but not a huge deal for now.
* master: dns: preserve custom resolver after channel destruction (envoyproxy#13820) docs: Further updates to quick-start (envoyproxy#13793) wasm: update V8 to v8.7.220.10. (envoyproxy#13568) test: adding a test for CONNECT to an IP address (envoyproxy#13818) [fuzz] Scaled Load balancer fuzz to 60k hosts (envoyproxy#13771) Removed Circle-CI reference. (envoyproxy#13824) wasm: strip only Custom Sections with precompiled Wasm modules. (envoyproxy#13775) examples: Add dynamic configuration (filesystem) sandbox (envoyproxy#13783) apple dns: resolve IP addresses without calling Apple APIs (envoyproxy#13698) Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: examples: Add dynamic configuration (filesystem) sandbox
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]