Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] fix legacy default #14101

Merged
merged 1 commit into from
Nov 23, 2020
Merged

[test] fix legacy default #14101

merged 1 commit into from
Nov 23, 2020

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Nov 19, 2020 •
edited
Loading

Signed-off-by: Asra Ali asraa@google.com

Commit Message: Because flags are default false, if use_new_codecs_in_integration_test flag wasn't explicitly set, it would be false. Swapped so that the flag refers to legacy codecs (used in compile time options), and by default, we use new codecs unless the flag is set FOR legacy.
Risk Level: Low
Testing: Tested integration tests.

Before on RouterDownstreamDisconnectBeforeResponseComplete:

[2020-11-19 15:03:04.236][20][trace][http] [source/common/http/http1/codec_impl_legacy.cc:465] [C3] completed header: key=host value=host
[2020-11-19 15:03:04.236][20][trace][http] [source/common/http/http1/codec_impl_legacy.cc:465] [C3] completed header: key=x-forwarded-proto value=http
[2020-11-19 15:03:04.236][20][trace][http] [source/common/http/http1/codec_impl_legacy.cc:465] [C3] completed header: key=x-request-id value=ccb817e4-b6c0-473b-bd5f-6e04e1f425c0
[2020-11-19 15:03:04.236][20][trace][http] [source/common/http/http1/codec_impl_legacy.cc:465] [C3] completed header: key=x-envoy-expected-rq-timeout-ms value=15000

After

[2020-11-19 14:56:33.979][20][trace][http] [source/common/http/http1/codec_impl.cc:489] [C3] completed header: key=host value=host
[2020-11-19 14:56:33.979][20][trace][http] [source/common/http/http1/codec_impl.cc:489] [C3] completed header: key=x-forwarded-proto value=http
[2020-11-19 14:56:33.979][20][trace][http] [source/common/http/http1/codec_impl.cc:489] [C3] completed header: key=x-request-id value=bbd41b99-2689-4470-b407-2f516cda4a1c
[2020-11-19 14:56:33.979][20][trace][http] [source/common/http/http1/codec_impl.cc:489] [C3] completed header: key=x-envoy-expected-rq-timeout-ms value=15000

If there's a way to make a config setting with a default value, let me know.

@asraa
fix default
1a8a80b 
Signed-off-by: Asra Ali <asraa@google.com>
alyssawilk
alyssawilk approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@asraa asraa merged commit 0592926 into envoyproxy:master Nov 23, 2020
qqustc pushed a commit to qqustc/envoy that referenced this pull request Nov 24, 2020
@asraa @qqustc
fix default codec in integration tests (envoyproxy#14101)
44ab44c 
Swapped test flag use in compile time options to refer to legacy codecs. By default, we use new codecs unless the flag is set FOR legacy.

Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Qin Qin <qqin@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssawilk alyssawilk alyssawilk approved these changes

Assignees

@alyssawilk alyssawilk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asraa @alyssawilk