Skip to content

Commit

Permalink
fix default codec in integration tests (envoyproxy#14101)
Browse files Browse the repository at this point in the history
Swapped test flag use in compile time options to refer to legacy codecs. By default, we use new codecs unless the flag is set FOR legacy.

Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Qin Qin <qqin@google.com>
  • Loading branch information
asraa authored and qqustc committed Nov 24, 2020
1 parent f46876c commit 44ab44c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions bazel/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -277,8 +277,8 @@ config_setting(
)

config_setting(
name = "enable_new_codecs_in_integration_tests",
values = {"define": "use_new_codecs_in_integration_tests=true"},
name = "enable_legacy_codecs_in_integration_tests",
values = {"define": "use_new_codecs_in_integration_tests=false"},
)

cc_proto_library(
Expand Down
6 changes: 3 additions & 3 deletions bazel/envoy_select.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,9 @@ def envoy_select_wasm_wasmtime(xs):
"//conditions:default": [],
})

# Select the given values if use legacy codecs in test is on in the current build.
# Select the given values by default and remove if use new codecs are disabled for current build.
def envoy_select_new_codecs_in_integration_tests(xs, repository = ""):
return select({
repository + "//bazel:enable_new_codecs_in_integration_tests": xs,
"//conditions:default": [],
repository + "//bazel:enable_legacy_codecs_in_integration_tests": [],
"//conditions:default": xs,
})

0 comments on commit 44ab44c

Please sign in to comment.