Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic proxy: fix flaky integration test 2 #28380

Merged

Conversation

wbpcode
Copy link
Member

@wbpcode wbpcode commented Jul 13, 2023

Commit Message: generic proxy: fix flaky integration test 2
Additional Description:

To close #27842.

Risk Level: low.
Testing: n/a.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
@wbpcode
Copy link
Member Author

wbpcode commented Jul 13, 2023

hope this is the final punch.

Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but just to make sure did you run this with --runs_per_test= something high?

@wbpcode
Copy link
Member Author

wbpcode commented Jul 14, 2023

LGTM but just to make sure did you run this with --runs_per_test= something high?

nope, I just learned about this options. Now, let me run it


here is the result. it should be ok. will leave this to you to merge. cc @alyssawilk

image

@yanavlasov yanavlasov merged commit 0f5801b into envoyproxy:main Jul 14, 2023
90 checks passed
@wbpcode wbpcode deleted the dev-fix-flaky-test-generic-proxy branch July 17, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake in TEST_P(IntegrationTest, DISABLED_MultipleRequests) {
3 participants