Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generic proxy: fix flaky integration test 2 #28380

Merged
merged 1 commit into from
Jul 14, 2023
Merged

generic proxy: fix flaky integration test 2 #28380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions contrib/generic_proxy/filters/network/test/integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,8 @@ class IntegrationTest : public testing::TestWithParam<Network::Address::IpVersio
void waitForUpstreamRequestForTest(uint64_t num_bytes, std::string* data) {
auto result = upstream_connection_->waitForData(num_bytes, data);
RELEASE_ASSERT(result, result.failure_message());
// Clear data for next test.
upstream_connection_->clearData();
}

// Send upstream response.
Expand Down Expand Up @@ -379,8 +381,7 @@ TEST_P(IntegrationTest, MultipleRequestsWithSameStreamId) {
cleanup();
}

// https://github.com/envoyproxy/envoy/issues/27842
TEST_P(IntegrationTest, DISABLED_MultipleRequests) {
TEST_P(IntegrationTest, MultipleRequests) {
FakeStreamCodecFactoryConfig codec_factory_config;
codec_factory_config.protocol_options_ = ProtocolOptions{true};
Registry::InjectFactory<CodecFactoryConfig> registration(codec_factory_config);
Expand Down
Loading