[ZK filter] Add per-opcode decoder error metrics #31138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Zhewei Hu <zhu@pinterest.com>
Signed-off-by: Zhewei Hu <zhu@pinterest.com>
Winbobob
force-pushed
the
add-per-opcode-decoder-error-metrics
branch
from
a1646ee
to
d99739f
Compare
|
Hi @JuniorHsu, please review this PR whenever you have a chance, thank you! |
mattklein123
approved these changes
Dec 3, 2023
lizan
pushed a commit
that referenced
this pull request
Dec 12, 2023
…31245) This is the prerequisite of reverting #30438 in order to fix the ZK proxy filter "Uncaught Exception" issue. Risk Level: Low Testing: Unit test Docs Changes: Revert doc changes in #31138 Release Notes: Revert release notes in #31138 Platform Specific Features: N/A Signed-off-by: Zhewei Hu <zhu@pinterest.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: [ZK filter] Add per-opcode decoder error metrics
Additional Description: Currently, the ZK proxy filter only emits one decoder error metric, which include all decoder errors. This PR tries to emit per-opcode decoder error metrics, which is helpful for debugging. These metrics can be turned on or off via a proto field
enable_per_opcode_decoder_error_metrics.Risk Level: Low
Testing: Unit test
Docs Changes: docs/root/configuration/listeners/network_filters/zookeeper_proxy_filter.rst
Release Notes: changelogs/current.yaml